From fdb6b286d48362de31698ef576cdccca13028d9a Mon Sep 17 00:00:00 2001 From: Alexandre Emsenhuber Date: Tue, 4 Oct 2011 14:32:07 +0000 Subject: [PATCH] Simplify a bit by adding the result inside the wfRunHooks() check --- includes/LogEventsList.php | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/includes/LogEventsList.php b/includes/LogEventsList.php index 284e537f4d..d2deeeaf97 100644 --- a/includes/LogEventsList.php +++ b/includes/LogEventsList.php @@ -707,16 +707,15 @@ class LogEventsList { } /* hook can return false, if we don't want the message to be emitted (Wikia BugId:7093) */ - if ( !wfRunHooks( 'LogEventsListShowLogExtract', array( &$s, $types, $page, $user, $param ) ) ) { - return $pager->getNumRows(); + if ( wfRunHooks( 'LogEventsListShowLogExtract', array( &$s, $types, $page, $user, $param ) ) ) { + // $out can be either an OutputPage object or a String-by-reference + if ( $out instanceof OutputPage ){ + $out->addHTML( $s ); + } else { + $out = $s; + } } - // $out can be either an OutputPage object or a String-by-reference - if( $out instanceof OutputPage ){ - $out->addHTML( $s ); - } else { - $out = $s; - } return $pager->getNumRows(); } -- 2.20.1