From aef29dba4aedf896874054c1f55b2270c3a54b14 Mon Sep 17 00:00:00 2001 From: Derk-Jan Hartman Date: Sat, 19 Feb 2011 21:03:52 +0000 Subject: [PATCH] Don't use getCheck, because the opts array is reused to generate the query for the RSS/Atom feed. getCheck checks for presence, not for true/false, so that was why rss feeds behaved as if deletedOnly was set. Follow up to r65651 Fixes bug #27546 --- includes/specials/SpecialContributions.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/specials/SpecialContributions.php b/includes/specials/SpecialContributions.php index 10dbb94cac..cfe2e010f8 100644 --- a/includes/specials/SpecialContributions.php +++ b/includes/specials/SpecialContributions.php @@ -58,7 +58,7 @@ class SpecialContributions extends SpecialPage { $this->opts['contribs'] = 'newbie'; } - $this->opts['deletedOnly'] = $wgRequest->getCheck( 'deletedOnly' ); + $this->opts['deletedOnly'] = $wgRequest->getBool( 'deletedOnly' ); if( !strlen( $target ) ) { $wgOut->addHTML( $this->getForm() ); @@ -67,7 +67,7 @@ class SpecialContributions extends SpecialPage { $this->opts['limit'] = $wgRequest->getInt( 'limit', $wgUser->getOption('rclimit') ); $this->opts['target'] = $target; - $this->opts['topOnly'] = $wgRequest->getCheck( 'topOnly' ); + $this->opts['topOnly'] = $wgRequest->getBool( 'topOnly' ); $nt = Title::makeTitleSafe( NS_USER, $target ); if( !$nt ) { -- 2.20.1