From ae88855e42d6a700e34e9861c55e84b6379545ad Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Sun, 15 Sep 2013 19:40:37 +0200 Subject: [PATCH] Drop unnecessary CSS selectors for a.external[href^="gopher://"] * They don't do anything anyway - gopher:// links are not styled by anything else, so they'd just get the same styles as regular external links. * They cause problems in browsers not supporting the attribute selector (like IE6), as the browser drops the entire rule, as required by the CSS specification. Also removed some code in monobook/IE60Fixes.css which seems to be simply a workaround for the issue described above. Bug: 31495 Change-Id: Ib33d47d5372dd73097bdcef8d00ebd073f6bbd68 --- skins/modern/main.css | 3 +-- skins/monobook/IE60Fixes.css | 9 --------- skins/monobook/main.css | 3 +-- skins/vector/screen.css | 3 +-- 4 files changed, 3 insertions(+), 15 deletions(-) diff --git a/skins/modern/main.css b/skins/modern/main.css index 47c320b89b..40fbfd7867 100644 --- a/skins/modern/main.css +++ b/skins/modern/main.css @@ -405,8 +405,7 @@ h1, h2, h3, h4, h5, h6 { text-decoration: none; color: white; } -#mw_content a.external, -#mw_content a.external[href ^="gopher://"] { +#mw_content a.external { /* @embed */ background: url(external.png) center right no-repeat; padding-right: 13px; diff --git a/skins/monobook/IE60Fixes.css b/skins/monobook/IE60Fixes.css index ec1ce430e7..534d333389 100644 --- a/skins/monobook/IE60Fixes.css +++ b/skins/monobook/IE60Fixes.css @@ -70,15 +70,6 @@ div#footer { #portal-personaltools { padding-bottom: 0.1em; } -#bodyContent a.external { - background: url(external.png) center right no-repeat; - padding-right: 13px; -} - -.rtl #bodyContent a.external { - background-image: url(external-rtl.png); - padding-right: 13px; -} .rtl a.feedlink { background-position: right; diff --git a/skins/monobook/main.css b/skins/monobook/main.css index 50b9e094f8..d8f25ebb3a 100644 --- a/skins/monobook/main.css +++ b/skins/monobook/main.css @@ -142,8 +142,7 @@ table.rimage { ** keep the whitespace in front of the ^=, hides rule from konqueror ** this is css3, the validator doesn't like it when validating as css2 */ -#bodyContent a.external, -#bodyContent a.external[href ^="gopher://"] { +#bodyContent a.external { /* @embed */ background: url(external-ltr.png) center right no-repeat; padding-right: 13px; diff --git a/skins/vector/screen.css b/skins/vector/screen.css index 8a69f843e0..c164c6dd55 100644 --- a/skins/vector/screen.css +++ b/skins/vector/screen.css @@ -703,8 +703,7 @@ pre, .mw-code { margin-top: 0; font-size: 1.6em; } -div#content a.external, -div#content a.external[href ^="gopher://"] { +div#content a.external { /* @embed */ background: url(images/external-link-ltr-icon.png) center right no-repeat; padding-right: 13px; -- 2.20.1