From 748721a3347b7992ba44078c669d59bea5f6852c Mon Sep 17 00:00:00 2001 From: umherirrender Date: Sat, 27 Sep 2014 12:05:29 +0200 Subject: [PATCH] Fix GitInfoTest::testValidJsonData on windows GitInfo.php is replacing DIRECTORY_SEPARATOR by '-'. On windows this is \, which was not set in the tests. 1) GitInfoTest::testValidJsonData Failed asserting that false is true. Change-Id: I1871c342b61a335b59a98755d8b824cc58c1543e --- tests/phpunit/includes/GitInfoTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/phpunit/includes/GitInfoTest.php b/tests/phpunit/includes/GitInfoTest.php index e22f50507e..c3539d0e7d 100644 --- a/tests/phpunit/includes/GitInfoTest.php +++ b/tests/phpunit/includes/GitInfoTest.php @@ -10,7 +10,7 @@ class GitInfoTest extends MediaWikiTestCase { } public function testValidJsonData() { - $dir = $GLOBALS['IP'] . '/testValidJsonData'; + $dir = $GLOBALS['IP'] . DIRECTORY_SEPARATOR . 'testValidJsonData'; $fixture = new GitInfo( $dir ); $this->assertTrue( $fixture->cacheIsComplete() ); -- 2.20.1