From 589bba9582ca5fe9c1dd9bc83b76e90f21ef4826 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Wed, 16 Jul 2014 04:12:12 +0200 Subject: [PATCH] mw.loader: Don't create addScript() callback if we don't need one $.Deferred#always ($.Callbacks#add) ignores undefined/null. No need to create an inline function that does nothing. Change-Id: Ifd96ac13e03242279e7d584cf91d899adadfed91 --- resources/src/mediawiki/mediawiki.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/resources/src/mediawiki/mediawiki.js b/resources/src/mediawiki/mediawiki.js index b22e24019e..57838d47db 100644 --- a/resources/src/mediawiki/mediawiki.js +++ b/resources/src/mediawiki/mediawiki.js @@ -1069,11 +1069,7 @@ crossDomain: true, cache: true, async: true - } ).always( function () { - if ( callback ) { - callback(); - } - } ); + } ).always( callback ); } else { /*jshint evil:true */ document.write( mw.html.element( 'script', { 'src': src }, '' ) ); -- 2.20.1