From 3ec9d41fb950ae8977cf9d696407ea23d43e9d68 Mon Sep 17 00:00:00 2001 From: jeroendedauw Date: Tue, 31 Jul 2012 20:33:10 +0200 Subject: [PATCH] Support deleting all rows Change-Id: I36ee33580261f39cb0ba69473f5afac9a5135853 --- includes/db/ORMTable.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/includes/db/ORMTable.php b/includes/db/ORMTable.php index a4396af4e4..bd6bf0b817 100644 --- a/includes/db/ORMTable.php +++ b/includes/db/ORMTable.php @@ -329,7 +329,7 @@ abstract class ORMTable implements IORMTable { public function delete( array $conditions, $functionName = null ) { return wfGetDB( DB_MASTER )->delete( $this->getName(), - $this->getPrefixedValues( $conditions ), + $conditions === array() ? '*' : $this->getPrefixedValues( $conditions ), $functionName ) !== false; // DatabaseBase::delete does not always return true for success as documented... } @@ -452,7 +452,10 @@ abstract class ORMTable implements IORMTable { public function updateSummaryFields( $summaryFields = null, array $conditions = array() ) { $this->setReadDb( DB_MASTER ); - foreach ( $this->select( null, $conditions ) as /* IORMRow */ $item ) { + /** + * @var IORMRow $item + */ + foreach ( $this->select( null, $conditions ) as $item ) { $item->loadSummaryFields( $summaryFields ); $item->setSummaryMode( true ); $item->save(); -- 2.20.1