From 08c589df945f52acc059a1f604fc22b4df5884b4 Mon Sep 17 00:00:00 2001 From: Trevor Parscal Date: Thu, 21 Apr 2011 00:02:27 +0000 Subject: [PATCH] Fixed mismatched cookie names, changed to using ":" instead of "-" between cookie basename and bucketing key to help make the cookie more readable and removed some extra space in an error message. --- resources/mediawiki/mediawiki.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/resources/mediawiki/mediawiki.js b/resources/mediawiki/mediawiki.js index 0665437053..725ddfb3b7 100644 --- a/resources/mediawiki/mediawiki.js +++ b/resources/mediawiki/mediawiki.js @@ -440,7 +440,7 @@ window.mediaWiki = new ( function( $ ) { 'tracked': false, 'expires': 30 }, options || {} ); - var cookie = $.cookie( 'mw.user.bucket-' + key ); + var cookie = $.cookie( 'mw.user.bucket:' + key ); var bucket = null; var version = 0; // Bucket information is stored as 2 integers, together as version:bucket like: "1:2" @@ -453,7 +453,7 @@ window.mediaWiki = new ( function( $ ) { } if ( bucket === null ) { if ( !$.isPlainObject( options.buckets ) ) { - throw 'Invalid buckets error. Object expected for options.buckets .'; + throw 'Invalid buckets error. Object expected for options.buckets.'; } version = Number( options.version ); // Find range @@ -474,11 +474,11 @@ window.mediaWiki = new ( function( $ ) { } if ( options.tracked ) { mw.loader.using( 'jquery.clickTracking', function() { - $.trackAction( 'mw.user.bucket-' + key + '@' + version + ':' + bucket ); + $.trackAction( 'mw.user.bucket:' + key + '@' + version + ':' + bucket ); } ); } $.cookie( - 'mw.userBuckets-' + key, + 'mw.user.bucket:' + key, version + ':' + bucket, { 'path': '/', 'expires': Number( options.expires ) } ); -- 2.20.1