From 066c4095e78dfdd31d847e834edf1d7b307f2bca Mon Sep 17 00:00:00 2001 From: Tobias Gritschacher Date: Mon, 18 Jun 2012 15:11:04 +0200 Subject: [PATCH] (bug 37458) permission errors running BaseDumpTest on Windows Change-Id: I58264c5f516f8dcb124d753b43a80b0875b0e974 --- tests/phpunit/maintenance/backupPrefetchTest.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/phpunit/maintenance/backupPrefetchTest.php b/tests/phpunit/maintenance/backupPrefetchTest.php index e92b289f0d..6ec802c772 100644 --- a/tests/phpunit/maintenance/backupPrefetchTest.php +++ b/tests/phpunit/maintenance/backupPrefetchTest.php @@ -17,11 +17,13 @@ class BaseDumpTest extends MediaWikiTestCase { private $dump = null; protected function tearDown() { - parent::tearDown(); - if ( $this->dump !== null ) { $this->dump->close(); } + + // Bug 37458, parent teardown need to be done after closing the + // dump or it might cause some permissions errors. + parent::tearDown(); } /** -- 2.20.1