From 036f84cfe7c2bb59de3dc4b93f558fff8b3fcfc7 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Wed, 26 Aug 2015 19:13:03 +0200 Subject: [PATCH] maintenance: Handle errors in deleteEqualMessages.php Follows-up 49107fcc2. Change-Id: I1b4b3f89a383a9b010d557ae0c6cbd767be60fb0 --- maintenance/deleteEqualMessages.php | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/maintenance/deleteEqualMessages.php b/maintenance/deleteEqualMessages.php index 73e65dc504..478e0d70c0 100644 --- a/maintenance/deleteEqualMessages.php +++ b/maintenance/deleteEqualMessages.php @@ -182,15 +182,20 @@ class DeleteEqualMessages extends Maintenance { $this->output( "\n* [[$title]]" ); $page = WikiPage::factory( $title ); $error = ''; // Passed by ref - // FIXME: Deletion failures should be reported, not silently ignored. - $page->doDeleteArticle( 'No longer required', false, 0, true, $error, $user ); + $success = $page->doDeleteArticle( 'No longer required', false, 0, true, $error, $user ); + if ( !$success ) { + $this->output( " (Failed!)" ); + } if ( $result['hasTalk'] && $doDeleteTalk ) { $title = Title::makeTitle( NS_MEDIAWIKI_TALK, $result['title'] ); $this->output( "\n* [[$title]]" ); $page = WikiPage::factory( $title ); $error = ''; // Passed by ref - $page->doDeleteArticle( 'Orphaned talk page of no longer required message', + $success = $page->doDeleteArticle( 'Orphaned talk page of no longer required message', false, 0, true, $error, $user ); + if ( !$success ) { + $this->output( " (Failed!)" ); + } } } $this->output( "\n\ndone!\n" ); -- 2.20.1