From: Brion Vibber <brion@users.mediawiki.org>
Date: Fri, 3 Jun 2011 18:39:10 +0000 (+0000)
Subject: Revert r89409: provided a default Database->listTables() implementation that didn... 
X-Git-Tag: 1.31.0-rc.0~29733
X-Git-Url: http://git.cyclocoop.org/url?a=commitdiff_plain;h=d97e37bbe6596a7814c3919f359fd043b6474d7e;p=lhc%2Fweb%2Fwiklou.git

Revert r89409: provided a default Database->listTables() implementation that didn't actually check the database, thus missing extension tables, any custom tables, any other tables being managed deliberately, and would be missing a matching table prefix if any.
---

diff --git a/includes/db/Database.php b/includes/db/Database.php
index 85e3b13d50..b26970eb0d 100644
--- a/includes/db/Database.php
+++ b/includes/db/Database.php
@@ -2445,12 +2445,7 @@ abstract class DatabaseBase implements DatabaseType {
 	 * @param $fname String: calling function name
 	 */
 	function listTables( $prefix = null, $fname = 'DatabaseBase::listTables' ) {
-		global $IP;
-		//throw new MWException( 'DatabaseBase::listTables is not implemented in descendant class' );
-		$tables = file_get_contents( "$IP/maintenance/tables.sql" );
-		preg_match_all('/create table \/\*_\*\/([a-z0-9_]*)/i', $tables, $matches, PREG_PATTERN_ORDER);
-		
-		return $matches[1];
+		throw new MWException( 'DatabaseBase::listTables is not implemented in descendant class' );
 	}
 
 	/**