From: Siebrand Mazeland <s.mazeland@xs4all.nl>
Date: Mon, 8 Oct 2012 00:05:49 +0000 (+0200)
Subject: Remove some unused local variables.
X-Git-Tag: 1.31.0-rc.0~22113^2
X-Git-Url: http://git.cyclocoop.org/url?a=commitdiff_plain;h=9816c181411bffa5cbc39c8e6e3c827a365753cd;p=lhc%2Fweb%2Fwiklou.git

Remove some unused local variables.

Also add a FIXME for a weird case.

Change-Id: I1f7f8a522fc49be85051a467455796c3f564584b
---

diff --git a/includes/ZipDirectoryReader.php b/includes/ZipDirectoryReader.php
index 0e84583f58..3a7c27ad76 100644
--- a/includes/ZipDirectoryReader.php
+++ b/includes/ZipDirectoryReader.php
@@ -622,7 +622,6 @@ class ZipDirectoryReader {
 			} else {
 				// Unsigned little-endian integer
 				$length = intval( $type );
-				$bytes = substr( $string, $pos, $length );
 
 				// Calculate the value. Use an algorithm which automatically
 				// upgrades the value to floating point if necessary.
diff --git a/includes/upload/UploadFromChunks.php b/includes/upload/UploadFromChunks.php
index 0542bba53a..b0e5fb6c71 100644
--- a/includes/upload/UploadFromChunks.php
+++ b/includes/upload/UploadFromChunks.php
@@ -76,7 +76,7 @@ class UploadFromChunks extends UploadFromFile {
 		$this->mFileKey = $this->mLocalFile->getFileKey();
 
 		// Output a copy of this first to chunk 0 location:
-		$status = $this->outputChunk( $this->mLocalFile->getPath() );
+		$this->outputChunk( $this->mLocalFile->getPath() );
 
 		// Update db table to reflect initial "chunk" state
 		$this->updateChunkStatus();
diff --git a/maintenance/backupTextPass.inc b/maintenance/backupTextPass.inc
index f1f0954617..81e61b7bd5 100644
--- a/maintenance/backupTextPass.inc
+++ b/maintenance/backupTextPass.inc
@@ -169,7 +169,7 @@ class TextPassDumper extends BackupDumper {
 		$this->xmlwriterobj = new XmlDumpWriter();
 
 		$input = fopen( $this->input, "rt" );
-		$result = $this->readDump( $input );
+		$this->readDump( $input );
 
 		if ( $this->spawnProc ) {
 			$this->closeSpawn();
diff --git a/maintenance/protect.php b/maintenance/protect.php
index 2f6aa1aedb..ff13bd6e69 100644
--- a/maintenance/protect.php
+++ b/maintenance/protect.php
@@ -58,6 +58,7 @@ class Protect extends Maintenance {
 			$this->error( "Invalid username", true );
 		}
 
+		// @todo FIXME: This is reset 7 lines down.
 		$restrictions = array( 'edit' => $protection, 'move' => $protection );
 
 		$t = Title::newFromText( $this->getArg() );