From: Brion Vibber <brion@users.mediawiki.org>
Date: Tue, 13 Dec 2011 19:58:44 +0000 (+0000)
Subject: bug 33035: Followup r105925: set to null rather than unset so we don't get an undefin... 
X-Git-Tag: 1.31.0-rc.0~25995
X-Git-Url: http://git.cyclocoop.org/url?a=commitdiff_plain;h=832dac129ad0eff1f68172aeedcda0c3bafb8cbb;p=lhc%2Fweb%2Fwiklou.git

bug 33035: Followup r105925: set to null rather than unset so we don't get an undefined property error later

Apparently the unset() in Language::setCode() could cause the later is_null check in getHtmlCode() to fail, though I could not reproduce it myself.
---

diff --git a/languages/Language.php b/languages/Language.php
index 7d4041a8f6..dfc0c8b886 100644
--- a/languages/Language.php
+++ b/languages/Language.php
@@ -3484,7 +3484,7 @@ class Language {
 	public function setCode( $code ) {
 		$this->mCode = $code;
 		// Ensure we don't leave an incorrect html code lying around
-		unset( $this->mHtmlCode );
+		$this->mHtmlCode = null;
 	}
 
 	/**