From: Ori Livneh <ori@wikimedia.org>
Date: Sat, 8 Nov 2014 23:28:30 +0000 (-0800)
Subject: Hide HHVM tag on Special:{Contributions,RecentChanges,...}
X-Git-Tag: 1.31.0-rc.0~11795^2~1
X-Git-Url: http://git.cyclocoop.org/url?a=commitdiff_plain;h=494989772cfce8805a10c2cd497880f6f6793896;p=lhc%2Fweb%2Fwiklou.git

Hide HHVM tag on Special:{Contributions,RecentChanges,...}

The coming weeks will see HHVM rolled out to progressively more users, which
will make the HHVM change tag even more ubiquitous than it is today. A small
but significant number of users have said that they find the tag irritating or
confusing, so let's temporarily hide it from the interface. (We only need this
until the migration is complete, because after that we can just go back and
delete the tag from the database.)

With this patch, the HHVM tag is not shown in change lists, but you can still
filter on it.

This could be implemented as a proper feature, configurable by adding items to
a $wgHiddenChangeTags array. I decided against doing that because I'm uneasy
about its application beyond this particular case.

My plan is to cherry-pick this change to the production branches (if it gets
merged) and leave it in master until the tag is expunged. This will happen long
before the 1.25 branch date of April 15, 2015.

Bug: 73181
Change-Id: Iec9befeba4fe77df0ddd4f056d82b3d4e2dd2199
---

diff --git a/includes/ChangeTags.php b/includes/ChangeTags.php
index a3c23608d9..87c6ce5c03 100644
--- a/includes/ChangeTags.php
+++ b/includes/ChangeTags.php
@@ -34,13 +34,17 @@ class ChangeTags {
 	public static function formatSummaryRow( $tags, $page ) {
 		global $wgLang;
 
+		$tags = explode( ',', $tags );
+
+		// XXX(Ori Livneh, 2014-11-08): remove once bug 73181 is resolved.
+		$tags = array_diff( $tags, array( 'HHVM', '' ) );
+
 		if ( !$tags ) {
 			return array( '', array() );
 		}
 
 		$classes = array();
 
-		$tags = explode( ',', $tags );
 		$displayTags = array();
 		foreach ( $tags as $tag ) {
 			$displayTags[] = Xml::tags(