Sort result of FileRepo::findBySha1

This sorts the result on Special:FileDuplicateSearch, which is unsorted,
when merged from different repos.

Adding File::compare similar to Title::compare for this

Change-Id: I32e8be92c6067f9e13f3ecd1039c337b0fc3e840

diff --git a/includes/filerepo/LocalRepo.php b/includes/filerepo/LocalRepo.php
index c616e16..dd0c947 100644 (file)
--- a/includes/filerepo/LocalRepo.php
+++ b/includes/filerepo/LocalRepo.php
@@ -235,7 +235,8 @@ class LocalRepo extends FileRepo {
                        'image',
                        LocalFile::selectFields(),
                        array( 'img_sha1' => $hash ),
-                       __METHOD__
+                       __METHOD__,
+                       array( 'ORDER BY' => 'img_name' )
                );
                
                $result = array();

diff --git a/includes/filerepo/RepoGroup.php b/includes/filerepo/RepoGroup.php
index 709655a..6b31b7e 100644 (file)
--- a/includes/filerepo/RepoGroup.php
+++ b/includes/filerepo/RepoGroup.php
@@ -259,6 +259,7 @@ class RepoGroup {
                foreach ( $this->foreignRepos as $repo ) {
                        $result = array_merge( $result, $repo->findBySha1( $hash ) );
                }
+               usort( $result, 'File::compare' );
                return $result;
        }
 

diff --git a/includes/filerepo/file/File.php b/includes/filerepo/file/File.php
index 065679a..d7c7533 100644 (file)
--- a/includes/filerepo/file/File.php
+++ b/includes/filerepo/file/File.php
@@ -245,6 +245,18 @@ abstract class File {
                }
        }
 
+       /**
+        * Callback for usort() to do file sorts by title
+        *
+        * @param $a File
+        * @param $b File
+        *
+        * @return Integer: result of title comparison
+        */
+       public static function compare( File $a, File $b ) {
+               return Title::compare( $a->getTitle(), $b->getTitle() );
+       }
+
        /**
         * Return the name of this file
         *