API param validation: Set strict mode for in_array

The in_array gives true when the allowed values contains a 0 as value,
for example by namespaces,

action=query&list=allpages&apnamespace=test|tset

was not rejected

Change-Id: I9220a955ffaf2bcb0d1d5b27c948af2f85714110

diff --git a/includes/api/ApiBase.php b/includes/api/ApiBase.php
index 741e908..84a6ed9 100644 (file)
--- a/includes/api/ApiBase.php
+++ b/includes/api/ApiBase.php
@@ -1081,7 +1081,7 @@ abstract class ApiBase extends ContextSource {
 
                if ( !$allowMultiple && count( $valuesList ) != 1 ) {
                        // Bug 33482 - Allow entries with | in them for non-multiple values
-                       if ( in_array( $value, $allowedValues ) ) {
+                       if ( in_array( $value, $allowedValues, true ) ) {
                                return $value;
                        }