Fix GitInfoTest::testValidJsonData on windows
authorumherirrender <umherirrender_de.wp@web.de>
Sat, 27 Sep 2014 10:05:29 +0000 (12:05 +0200)
committerBryanDavis <bdavis@wikimedia.org>
Tue, 30 Sep 2014 20:44:45 +0000 (20:44 +0000)
GitInfo.php is replacing DIRECTORY_SEPARATOR by '-'.
On windows this is \, which was not set in the tests.

1) GitInfoTest::testValidJsonData
Failed asserting that false is true.

Change-Id: I1871c342b61a335b59a98755d8b824cc58c1543e

tests/phpunit/includes/GitInfoTest.php

index e22f505..c3539d0 100644 (file)
@@ -10,7 +10,7 @@ class GitInfoTest extends MediaWikiTestCase {
        }
 
        public function testValidJsonData() {
-               $dir = $GLOBALS['IP'] . '/testValidJsonData';
+               $dir = $GLOBALS['IP'] . DIRECTORY_SEPARATOR . 'testValidJsonData';
                $fixture = new GitInfo( $dir );
 
                $this->assertTrue( $fixture->cacheIsComplete() );