Revert r34029 - "(bug 11659) Urldecode image names in galleries"

The indiscriminate use of urldecode() here breaks image names containing a + character.

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index e634c7c..b101abf 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -224,7 +224,6 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 13866) skins/common/shared.css - invalid attribute fixing
 * Hide edit section links on Special:Undelete
 * (bug 13860) Fix "Justify paragraphs" option for Modern skin
-* (bug 11659) Urldecode image names in galleries
 * (bug 13168) accessibility links in Modern skin link to wrong anchor id
 * (bug 13185) No line break after 'subpages' class in Modern skin
 * (bug 13583) No "poweredby" in Modern skin

diff --git a/includes/Parser.php b/includes/Parser.php
index 669d43d..a5162d6 100644 (file)
--- a/includes/Parser.php
+++ b/includes/Parser.php
@@ -4337,7 +4337,7 @@ class Parser
                        if ( count( $matches ) == 0 ) {
                                continue;
                        }
-                       $tp = Title::newFromText( urldecode( $matches[1] ) );
+                       $tp = Title::newFromText( $matches[1] );
                        $nt =& $tp;
                        if( is_null( $nt ) ) {
                                # Bogus title. Ignore these so we don't bomb out later.