Added user Id sanity check to setUsernameBitfields() for bug 34755.
authorAaron Schulz <aaron@users.mediawiki.org>
Thu, 29 Mar 2012 23:31:39 +0000 (16:31 -0700)
committerAaron Schulz <aaron@users.mediawiki.org>
Thu, 29 Mar 2012 23:32:00 +0000 (16:32 -0700)
Change-Id: I44288d199d86045151f8184f7abaa3df886d9d99

includes/revisiondelete/RevisionDeleteUser.php

index fe424ef..0e965c8 100644 (file)
@@ -34,10 +34,10 @@ class RevisionDeleteUser {
         * @return bool
         */
        private static function setUsernameBitfields( $name, $userId, $op, $dbw ) {
-               if( $op !== '|' && $op !== '&' ){
+               if ( !$userId || ( $op !== '|' && $op !== '&' ) ) {
                        return false; // sanity check
                }
-               if( !$dbw instanceof DatabaseBase ){
+               if ( !$dbw instanceof DatabaseBase ) {
                        $dbw = wfGetDB( DB_MASTER );
                }