From: Brion Vibber <brion@users.mediawiki.org>
Date: Sun, 20 Mar 2005 10:31:55 +0000 (+0000)
Subject: Fail gracefully when given bogus revisions
X-Git-Tag: 1.5.0alpha1~559
X-Git-Url: http://git.cyclocoop.org/geomaker.php?a=commitdiff_plain;h=92bb6aff58f5a4ac66d3023dc6ab8b9e777a2432;p=lhc%2Fweb%2Fwiklou.git

Fail gracefully when given bogus revisions
---

diff --git a/includes/DifferenceEngine.php b/includes/DifferenceEngine.php
index 767c736d5e..93cec347d8 100644
--- a/includes/DifferenceEngine.php
+++ b/includes/DifferenceEngine.php
@@ -270,6 +270,9 @@ class DifferenceEngine {
 		} else {
 			$this->newRev =& Revision::newFromTitle( $wgTitle );
 		}
+		if( is_null( $this->newRev ) ) {
+			return false;
+		}
 		
 		if( $this->newRev->isCurrent() ) {
 			$this->mPagetitle = htmlspecialchars( wfMsg( 'currentrev' ) );
@@ -290,6 +293,9 @@ class DifferenceEngine {
 			$this->oldRev =& $this->newRev->getPrevious();
 			$this->mOldid = $this->oldRev->getId();
 		}
+		if( is_null( $this->oldRev ) ) {
+			return false;
+		}
 			
 		$this->mOldPage = $this->oldRev->getTitle();