From e262d63d3eb08354e9d3939e7f3582b7d72a9803 Mon Sep 17 00:00:00 2001 From: umherirrender Date: Sun, 20 Jul 2014 22:31:58 +0200 Subject: [PATCH] Remove return value from QueryPage::execute The parent SpecialPage::execute also has no return and not all return statements in QueryPage::execute actual return a value Change-Id: If7a38ca5ed1107b6a5a740acae54295534950696 --- includes/specialpage/QueryPage.php | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/includes/specialpage/QueryPage.php b/includes/specialpage/QueryPage.php index 3a83d2bad8..b8fc05e5b6 100644 --- a/includes/specialpage/QueryPage.php +++ b/includes/specialpage/QueryPage.php @@ -470,7 +470,6 @@ abstract class QueryPage extends SpecialPage { * This is the actual workhorse. It does everything needed to make a * real, honest-to-gosh query page. * @param string $par - * @return int */ function execute( $par ) { global $wgQueryCacheLimit, $wgDisableQueryPageUpdate; @@ -488,7 +487,7 @@ abstract class QueryPage extends SpecialPage { if ( $this->isCached() && !$this->isCacheable() ) { $out->addWikiMsg( 'querypage-disabled' ); - return 0; + return; } $out->setSyndicated( $this->isSyndicated() ); @@ -578,8 +577,6 @@ abstract class QueryPage extends SpecialPage { } $out->addHTML( Xml::closeElement( 'div' ) ); - - return min( $this->numRows, $this->limit ); # do not return the one extra row, if exist } /** -- 2.20.1