From d7059cc033b9974e90d335b7045dca0f6604b28c Mon Sep 17 00:00:00 2001 From: Alex Monk Date: Fri, 26 Jun 2015 19:03:15 +0100 Subject: [PATCH] UserrightsPage: Avoid passing null target Bug: T103945 Change-Id: I80598ce6d12a73a7a3c399fbacc2a253999177b2 --- includes/specials/SpecialUserrights.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/includes/specials/SpecialUserrights.php b/includes/specials/SpecialUserrights.php index ab539515d2..0158fdb3eb 100644 --- a/includes/specials/SpecialUserrights.php +++ b/includes/specials/SpecialUserrights.php @@ -106,7 +106,7 @@ class UserrightsPage extends SpecialPage { } } - if ( User::getCanonicalName( $this->mTarget ) === $user->getName() ) { + if ( $this->mTarget !== null && User::getCanonicalName( $this->mTarget ) === $user->getName() ) { $this->isself = true; } @@ -145,6 +145,7 @@ class UserrightsPage extends SpecialPage { if ( $request->wasPosted() && $request->getCheck( 'saveusergroups' ) && + $this->mTarget !== null && $user->matchEditToken( $request->getVal( 'wpEditToken' ), $this->mTarget ) ) { // save settings -- 2.20.1