From d441507260afc8c987403034587843f890008aaa Mon Sep 17 00:00:00 2001 From: Derick Alangi Date: Wed, 11 Sep 2019 18:41:05 +0100 Subject: [PATCH] deferred: Fix MW version number when hard deprecating to '1.34' Should be string or bool and not a float. The reason 49bbfc7 was not triggered is because the deprecated code path is no longer being executed in production. Change-Id: Ieeffb8a6cc7177c52b4c54d66152c90ded1dc248 --- includes/deferred/SearchUpdate.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/includes/deferred/SearchUpdate.php b/includes/deferred/SearchUpdate.php index a508746c55..84f6fc0eaf 100644 --- a/includes/deferred/SearchUpdate.php +++ b/includes/deferred/SearchUpdate.php @@ -50,7 +50,7 @@ class SearchUpdate implements DeferrableUpdate { */ public function __construct( $id, $title, $c = null ) { if ( is_string( $title ) ) { - wfDeprecated( __METHOD__ . " with a string for the title", 1.34 ); + wfDeprecated( __METHOD__ . " with a string for the title", '1.34' ); $this->title = Title::newFromText( $title ); if ( $this->title === null ) { throw new InvalidArgumentException( "Cannot construct the title: $title" ); @@ -62,10 +62,10 @@ class SearchUpdate implements DeferrableUpdate { $this->id = $id; // is_string() check is back-compat for ApprovedRevs if ( is_string( $c ) ) { - wfDeprecated( __METHOD__ . " with a string for the content", 1.34 ); + wfDeprecated( __METHOD__ . " with a string for the content", '1.34' ); $c = new TextContent( $c ); } elseif ( is_bool( $c ) ) { - wfDeprecated( __METHOD__ . " with a boolean for the content", 1.34 ); + wfDeprecated( __METHOD__ . " with a boolean for the content", '1.34' ); $c = null; } $this->content = $c; -- 2.20.1