From c9e365df68732f8ba12838305a26e43327d38dee Mon Sep 17 00:00:00 2001 From: Derick Alangi Date: Sat, 11 May 2019 16:05:58 +0100 Subject: [PATCH] jobqueue: Remove deprecated unused method pushLazyJobs() Was deprecated in 1.33 and is no longer used anywhere. See usage below; Usage ===== https://codesearch.wmflabs.org/search/?q=%5CbpushLazyJobs%5Cb&i=nope&files=&repos= Bug: T220656 Change-Id: I4d3f6bc019b8ebc7e504d841fc75acdb08061cb4 --- RELEASE-NOTES-1.34 | 1 + includes/jobqueue/JobQueueGroup.php | 15 --------------- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/RELEASE-NOTES-1.34 b/RELEASE-NOTES-1.34 index faab1e41be..6113a5f33b 100644 --- a/RELEASE-NOTES-1.34 +++ b/RELEASE-NOTES-1.34 @@ -154,6 +154,7 @@ because of Phabricator reports. * ApiQueryBase::prepareUrlQuerySearchString(), deprecated in 1.33, has been removed. * ChangeTags::purgeTagUsageCache(), deprecated in 1.33, has been removed. +* JobQueueGroup::pushLazyJobs(), deprecated in 1.33, has been removed. * … === Deprecations in 1.34 === diff --git a/includes/jobqueue/JobQueueGroup.php b/includes/jobqueue/JobQueueGroup.php index 83e5fb24bf..7a0d4eaff1 100644 --- a/includes/jobqueue/JobQueueGroup.php +++ b/includes/jobqueue/JobQueueGroup.php @@ -187,10 +187,6 @@ class JobQueueGroup { /** * Buffer jobs for insertion via push() or call it now if in CLI mode * - * Note that pushLazyJobs() is registered as a deferred update just before - * DeferredUpdates::doUpdates() in MediaWiki and JobRunner classes in order - * to be executed as the very last deferred update (T100085, T154425). - * * @param IJobSpecification|IJobSpecification[] $jobs A single Job or a list of Jobs * @return void * @since 1.26 @@ -214,17 +210,6 @@ class JobQueueGroup { DeferredUpdates::addUpdate( new JobQueueEnqueueUpdate( $this->domain, $jobs ) ); } - /** - * Push all jobs buffered via lazyPush() into their respective queues - * - * @return void - * @since 1.26 - * @deprecated Since 1.33 Not needed anymore - */ - public static function pushLazyJobs() { - wfDeprecated( __METHOD__, '1.33' ); - } - /** * Pop a job off one of the job queues * -- 2.20.1