From 8a3a1fa6a31547b69c4363d92528477f0b80b8e6 Mon Sep 17 00:00:00 2001
From: Tim Starling <tstarling@users.mediawiki.org>
Date: Sat, 15 May 2004 03:38:35 +0000
Subject: [PATCH] Fixed incorrect reference syntax

---
 includes/Skin.php | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/includes/Skin.php b/includes/Skin.php
index a7eb604f3e..4e9eff90ce 100644
--- a/includes/Skin.php
+++ b/includes/Skin.php
@@ -1633,36 +1633,36 @@ class Skin {
 	/* these are used extensively in SkinPHPTal, but also some other places */
 	/*static*/ function makeSpecialUrl( $name, $urlaction='' ) {
 		$title = Title::makeTitle( NS_SPECIAL, $name );
-		$this->checkTitle(&$title, &$name);	
+		$this->checkTitle($title, $name);	
 		return $title->getLocalURL( $urlaction );
 	}
 	/*static*/ function makeTalkUrl ( $name, $urlaction='' ) {
 		$title = Title::newFromText( $name );
 		$title = $title->getTalkPage();
-		$this->checkTitle(&$title, &$name);	
+		$this->checkTitle($title, $name);	
 		return $title->getLocalURL( $urlaction );
 	}
 	/*static*/ function makeArticleUrl ( $name, $urlaction='' ) {
 		$title = Title::newFromText( $name );
 		$title= $title->getSubjectPage();
-		$this->checkTitle(&$title, &$name);	
+		$this->checkTitle($title, $name);	
 		return $title->getLocalURL( $urlaction );
 	}
 	/*static*/ function makeI18nUrl ( $name, $urlaction='' ) {
 		$title = Title::newFromText( wfMsg($name) );
-		$this->checkTitle(&$title, &$name);	
+		$this->checkTitle($title, $name);	
 		return $title->getLocalURL( $urlaction );
 	}
 	/*static*/ function makeUrl ( $name, $urlaction='' ) {
 		$title = Title::newFromText( $name );
-		$this->checkTitle(&$title, &$name);	
+		$this->checkTitle($title, $name);	
 		return $title->getLocalURL( $urlaction ); 
 	}
 	
 	/* these return an array with the 'href' and boolean 'exists' */
 	/*static*/ function makeUrlDetails ( $name, $urlaction='' ) {
 		$title = Title::newFromText( $name );
-		$this->checkTitle(&$title, &$name);
+		$this->checkTitle($title, $name);
 		return array( 
 			'href' => $title->getLocalURL( $urlaction ),
 			'exists' => $title->getArticleID() != 0?true:false
@@ -1671,7 +1671,7 @@ class Skin {
 	/*static*/ function makeTalkUrlDetails ( $name, $urlaction='' ) {
 		$title = Title::newFromText( $name );
 		$title = $title->getTalkPage();
-		$this->checkTitle(&$title, &$name);
+		$this->checkTitle($title, $name);
 		return array( 
 			'href' => $title->getLocalURL( $urlaction ),
 			'exists' => $title->getArticleID() != 0?true:false
@@ -1680,7 +1680,7 @@ class Skin {
 	/*static*/ function makeArticleUrlDetails ( $name, $urlaction='' ) {
 		$title = Title::newFromText( $name );
 		$title= $title->getSubjectPage();
-		$this->checkTitle(&$title, &$name);
+		$this->checkTitle($title, $name);
 		return array( 
 			'href' => $title->getLocalURL( $urlaction ),
 			'exists' => $title->getArticleID() != 0?true:false
@@ -1688,15 +1688,15 @@ class Skin {
 	}
 	/*static*/ function makeI18nUrlDetails ( $name, $urlaction='' ) {
 		$title = Title::newFromText( wfMsg($name) );
-		$this->checkTitle(&$title, &$name);
+		$this->checkTitle($title, $name);
 		return array( 
 			'href' => $title->getLocalURL( $urlaction ),
 			'exists' => $title->getArticleID() != 0?true:false
 		); 
 	}
 
-	# make sure we have some title to operate on, mind the '&'
-	/*static*/ function &checkTitle ( $title, $name ) { 
+	# make sure we have some title to operate on
+	/*static*/ function checkTitle ( &$title, &$name ) { 
 		if(!is_object($title)) {
 			$title = Title::newFromText( $name );
 			if(!is_object($title)) {
-- 
2.20.1