From 8315cbe263c0b0a72d4cffc9f5551b5659a65850 Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Thu, 17 May 2007 18:33:00 +0000 Subject: [PATCH] * Right-align diff line numbers in RTL language display Use .diff-lineno class instead of hardcoding a and an alignment. Leaving default alignment does the right thing in both LTR and RTL; forcing left was unnecessary. Also swapping alignment for the +/- marker column to improve look on RTL. --- RELEASE-NOTES | 1 + includes/DefaultSettings.php | 2 +- includes/DifferenceEngine.php | 4 ++-- skins/common/diff.css | 6 ++++++ 4 files changed, 10 insertions(+), 3 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index dddfec6262..1533729b5e 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -64,6 +64,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN and the dupes removed from the default skin files. Skins can still override the default rules. * (bug 1229) Balance columns in diff display evenly +* Right-align diff line numbers in RTL language display == MediaWiki API changes since 1.10 == diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php index aaff730c55..de3cdaa819 100644 --- a/includes/DefaultSettings.php +++ b/includes/DefaultSettings.php @@ -1125,7 +1125,7 @@ $wgCacheEpoch = '20030516000000'; * to ensure that client-side caches don't keep obsolete copies of global * styles. */ -$wgStyleVersion = '70'; +$wgStyleVersion = '71'; # Server-side caching: diff --git a/includes/DifferenceEngine.php b/includes/DifferenceEngine.php index 5634a4c04c..3b9f885cf3 100644 --- a/includes/DifferenceEngine.php +++ b/includes/DifferenceEngine.php @@ -1734,8 +1734,8 @@ class TableDiffFormatter extends DiffFormatter } function _block_header( $xbeg, $xlen, $ybeg, $ylen ) { - $r = '\n" . - '\n"; + $r = '\n" . + '\n"; return $r; } diff --git a/skins/common/diff.css b/skins/common/diff.css index 0e7fd0627c..f8825a39e5 100644 --- a/skins/common/diff.css +++ b/skins/common/diff.css @@ -11,6 +11,12 @@ td.diff-ntitle { td.diff-marker { text-align: right; } +.rtl td.diff-marker { + text-align: left; +} +td.diff-lineno { + font-weight: bold; +} td.diff-addedline { background: #cfc; font-size: smaller; -- 2.20.1