From 614028768bbeb6143808544a68c9e72af648e031 Mon Sep 17 00:00:00 2001
From: Aaron Schulz <aschulz@wikimedia.org>
Date: Thu, 15 Dec 2016 19:32:26 -0800
Subject: [PATCH] Fix various minor IDEA warnings in LoadBalancer

Change-Id: Ic65a04ca1b988fe36e088709d7dc4e981670cb62
---
 includes/libs/rdbms/loadbalancer/LoadBalancer.php | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/includes/libs/rdbms/loadbalancer/LoadBalancer.php b/includes/libs/rdbms/loadbalancer/LoadBalancer.php
index 8601785b19..baab031566 100644
--- a/includes/libs/rdbms/loadbalancer/LoadBalancer.php
+++ b/includes/libs/rdbms/loadbalancer/LoadBalancer.php
@@ -441,12 +441,15 @@ class LoadBalancer implements ILoadBalancer {
 
 	/**
 	 * @param int $i
-	 * @return IDatabase
+	 * @return IDatabase|bool
 	 */
 	public function getAnyOpenConnection( $i ) {
 		foreach ( $this->mConns as $connsByServer ) {
 			if ( !empty( $connsByServer[$i] ) ) {
-				return reset( $connsByServer[$i] );
+				/** @var $serverConns IDatabase[] */
+				$serverConns = $connsByServer[$i];
+
+				return reset( $serverConns );
 			}
 		}
 
-- 
2.20.1