From 567f93198ae548aad1c7133bf4fb4a100b5f247f Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Sun, 6 Feb 2005 05:51:36 +0000 Subject: [PATCH] * (bug 1477) hide details of SQL error messages by default Set $wgShowSQLErrors = true for debugging. Removed unused settings $wgBufferSQLResults and $wgShowSQLErrors. --- includes/DefaultSettings.php | 12 ++++++------ includes/SpecialSitesettings.php | 1 - 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php index bb6bba8eb4..26a282c652 100644 --- a/includes/DefaultSettings.php +++ b/includes/DefaultSettings.php @@ -286,9 +286,6 @@ $wgDBtransactions = false; $wgDBmysql4 = false; $wgSqlTimeout = 30; -/** use buffered queries by default */ -$wgBufferSQLResults = true; - /** * Other wikis on this site, can be administered from a single developer * account. @@ -414,9 +411,12 @@ $wgReadOnly = false; $wgLogQueries = false; $wgDebugDumpSql = false; -/** Whether to disable automatic generation of "we're sorry, but there has been - * a database error" pages. */ -$wgIgnoreSQLErrors = false; +/** + * Whether to show "we're sorry, but there has been a database error" pages. + * Displaying errors aids in debugging, but may display information useful + * to an attacker. + */ +$wgShowSQLErrors = false; # Should [[Category:Dog]] on a page associate it with the # category "Dog"? (a link to that category page will be diff --git a/includes/SpecialSitesettings.php b/includes/SpecialSitesettings.php index 51eeaeef0f..7438e14ca9 100644 --- a/includes/SpecialSitesettings.php +++ b/includes/SpecialSitesettings.php @@ -170,7 +170,6 @@ class SiteSettingsForm extends HTMLForm { $this->checkbox( 'wgDebugComments' ) . $this->checkbox( 'wgLogQueries' ) . $this->checkbox( 'wgDebugDumpSql' ) . - $this->checkbox( 'wgIgnoreSQLErrors' ) . $this->fieldset( 'sitesettings-debugging-profiling', $this->checkbox( 'wgProfiling' ) . $this->textbox( 'wgProfileLimit' ) . -- 2.20.1