From 4ac4b16f323e7a347f89baad87c819ceb2cda529 Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Tue, 4 Aug 2009 23:24:58 +0000 Subject: [PATCH] Add fixme note to replace 'mysql' command-line callout with proper usage of a second unbuffered DB connection --- maintenance/populateSha1.php | 1 + 1 file changed, 1 insertion(+) diff --git a/maintenance/populateSha1.php b/maintenance/populateSha1.php index 4233cb2a10..72ef9461dd 100644 --- a/maintenance/populateSha1.php +++ b/maintenance/populateSha1.php @@ -56,6 +56,7 @@ class PopulateSha1 extends Maintenance { $batch = array(); if ( $method == 'pipe' ) { + // @fixme kill this and replace with a second unbuffered DB connection. global $wgDBuser, $wgDBserver, $wgDBpassword, $wgDBname; $cmd = 'mysql -u' . wfEscapeShellArg( $wgDBuser ) . ' -h' . wfEscapeShellArg( $wgDBserver ) . -- 2.20.1