From 406988f0993ec842a9a794fbc343be56aadeb070 Mon Sep 17 00:00:00 2001 From: Antoine Musso Date: Sat, 7 Jul 2012 20:09:45 +0200 Subject: [PATCH] CLI install exited with 0 status code The CliInstaller used the '0' exit code whenever the status was not OK. That makes third party script assuming the install actually ran fine since a 0 exit code is mostly considered as a success. By sending an error code > 0 (here 1), our automatic installers will be able to catch the failure and stop proceeding. I had that issue with a Jenkins job which ran the CLI installer and kept continuing although there was an error about LocalSettings.php already existing. Change-Id: I4f4727df85c09c0a04e4630df91c6213dfce6e9a --- includes/installer/CliInstaller.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/installer/CliInstaller.php b/includes/installer/CliInstaller.php index 752e2149ba..28b34a8fe7 100644 --- a/includes/installer/CliInstaller.php +++ b/includes/installer/CliInstaller.php @@ -187,7 +187,7 @@ class CliInstaller extends Installer { if ( !$status->isOk() ) { echo "\n"; - exit; + exit( 1 ); } } -- 2.20.1