From 17b05db14c2114ae5c33ae5598d52913ca146c2b Mon Sep 17 00:00:00 2001 From: Federico Leva Date: Tue, 12 May 2015 21:00:46 +0200 Subject: [PATCH] wl_notificationtimestamp code comments typo, false statement The timestamp is updated earlier. Change-Id: I5c40affc346b85fa5350c381ee3f93c86b26d454 --- includes/mail/EmailNotification.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/includes/mail/EmailNotification.php b/includes/mail/EmailNotification.php index 81c4e38d32..3fd9efff12 100644 --- a/includes/mail/EmailNotification.php +++ b/includes/mail/EmailNotification.php @@ -61,7 +61,7 @@ class EmailNotification { * @param User $editor The editor that triggered the update. Their notification * timestamp will not be updated(they have already seen it) * @param Title $title The title to update timestamps for - * @param string $timestamp Set the upate timestamp to this value + * @param string $timestamp Set the update timestamp to this value * @return int[] */ public static function updateWatchlistTimestamp( User $editor, Title $title, $timestamp ) { @@ -110,7 +110,6 @@ class EmailNotification { /** * Send emails corresponding to the user $editor editing the page $title. - * Also updates wl_notificationtimestamp. * * May be deferred via the job queue. * @@ -187,8 +186,8 @@ class EmailNotification { * Immediate version of notifyOnPageChange(). * * Send emails corresponding to the user $editor editing the page $title. - * Also updates wl_notificationtimestamp. * + * @note Do not call directly. Use notifyOnPageChange so that wl_notificationtimestamp is updated. * @param User $editor * @param Title $title * @param string $timestamp Edit timestamp -- 2.20.1