From 13353d931624ac10d0a01ea1fd905efe9d487ab1 Mon Sep 17 00:00:00 2001
From: Max Semenik <maxsem@users.mediawiki.org>
Date: Fri, 12 Nov 2010 18:47:33 +0000
Subject: [PATCH] Fix for r74950: use wfEscapeShellArg()

---
 includes/installer/Installer.php | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/includes/installer/Installer.php b/includes/installer/Installer.php
index 86444a543e..c575b152a3 100644
--- a/includes/installer/Installer.php
+++ b/includes/installer/Installer.php
@@ -890,10 +890,7 @@ abstract class Installer {
 					return $command;
 				}
 
-				if ( wfIsWindows() ) {
-					$command = "\"$command\"";
-				}
-				$file = str_replace( '$1', $command, $versionInfo[0] );
+				$file = str_replace( '$1', wfEscapeShellArg( $command ), $versionInfo[0] );
 				if ( strstr( wfShellExec( $file ), $versionInfo[1] ) !== false ) {
 					return $command;
 				}
-- 
2.20.1