From: Aaron Schulz Date: Tue, 18 Dec 2012 01:11:15 +0000 (-0800) Subject: [JobQueue] Cleaned up DuplicateJob factory function. X-Git-Tag: 1.31.0-rc.0~21246^2 X-Git-Url: http://git.cyclocoop.org/fichier?a=commitdiff_plain;h=61054a45c0f7eaf88b9be28085afb886dc0ccac6;p=lhc%2Fweb%2Fwiklou.git [JobQueue] Cleaned up DuplicateJob factory function. Change-Id: If2303776bdbc9b78a07907e7b290c2da5af7e493 --- diff --git a/includes/job/jobs/DuplicateJob.php b/includes/job/jobs/DuplicateJob.php index 6e056dea62..23418e303d 100644 --- a/includes/job/jobs/DuplicateJob.php +++ b/includes/job/jobs/DuplicateJob.php @@ -45,11 +45,11 @@ final class DuplicateJob extends Job { * @return Job */ public static function newFromJob( Job $job ) { - $job = new self( $job->getTitle(), $job->getParams(), $job->getId() ); - $job->command = $job->getType(); - $job->params = is_array( $job->params ) ? $job->params : array(); - $job->params = array( 'isDuplicate' => true ) + $job->params; - return $job; + $djob = new self( $job->getTitle(), $job->getParams(), $job->getId() ); + $djob->command = $job->getType(); + $djob->params = is_array( $djob->params ) ? $djob->params : array(); + $djob->params = array( 'isDuplicate' => true ) + $djob->params; + return $djob; } public function run() {