From: Aaron Schulz <aschulz@wikimedia.org>
Date: Thu, 25 Oct 2018 03:34:41 +0000 (-0700)
Subject: Make testFormatValueRestrictions() account for $wgArticlePath to avoid failures
X-Git-Tag: 1.34.0-rc.0~3648^2
X-Git-Url: http://git.cyclocoop.org/fichier?a=commitdiff_plain;h=4108381175099e0847475834b439dfe63c616833;p=lhc%2Fweb%2Fwiklou.git

Make testFormatValueRestrictions() account for $wgArticlePath to avoid failures

Follows-up 170c49d61cb84411.

Change-Id: I37a57b5ece939c5743b7d08d02ce41c71daee5eb
---

diff --git a/tests/phpunit/includes/specials/pagers/BlockListPagerTest.php b/tests/phpunit/includes/specials/pagers/BlockListPagerTest.php
index a05cbbd545..80df1d0866 100644
--- a/tests/phpunit/includes/specials/pagers/BlockListPagerTest.php
+++ b/tests/phpunit/includes/specials/pagers/BlockListPagerTest.php
@@ -111,6 +111,8 @@ class BlockListPagerTest extends MediaWikiTestCase {
 	 * @covers ::formatValue
 	 */
 	public function testFormatValueRestrictions() {
+		$this->setMwGlobals( 'wgArticlePath', '/wiki/$1' );
+
 		$pager = new BlockListPager( new SpecialPage(),  [] );
 
 		$row = (object)[
@@ -140,10 +142,11 @@ class BlockListPagerTest extends MediaWikiTestCase {
 
 		$formatted = $pager->formatValue( 'ipb_params', '' );
 		$this->assertEquals( '<ul><li>'
+			// FIXME: Expectation value should not be dynamic
+			// and must not depend on a localisation message.
+			// TODO: Mock the message or consider using qqx.
 			. wfMessage( 'blocklist-editing' )->text()
-			. '<ul><li><a href="/index.php/'
-			. $title->getDBKey()
-			. '" title="'
+			. '<ul><li><a href="/wiki/Victor_Frankenstein" title="'
 			. $pageName
 			. '">'
 			. $pageName