From: Erik Bernhardson <ebernhardson@wikimedia.org>
Date: Mon, 3 Mar 2014 22:35:11 +0000 (-0800)
Subject: Only generate date header when rendering is guaranteed
X-Git-Tag: 1.31.0-rc.0~16751^2
X-Git-Url: http://git.cyclocoop.org/fichier?a=commitdiff_plain;h=4029c76d2580e390eafbd68011513b9fdf6f19d2;p=lhc%2Fweb%2Fwiklou.git

Only generate date header when rendering is guaranteed

The OldChangesListRecentChangesLine hook can skip rendering of
a particular rc line.  If that line was the one that would have
added a new date header then no date header is output.  The
pushes checking for a new date header until after we know a
line will be output so none of the headers get lost.

Change-Id: I64ddd99c6af0b562802504b803563cf77fc2eb28
---

diff --git a/includes/changes/OldChangesList.php b/includes/changes/OldChangesList.php
index 9cb1146162..458f21a139 100644
--- a/includes/changes/OldChangesList.php
+++ b/includes/changes/OldChangesList.php
@@ -37,9 +37,6 @@ class OldChangesList extends ChangesList {
 		# Should patrol-related stuff be shown?
 		$unpatrolled = $this->showAsUnpatrolled( $rc );
 
-		$dateheader = ''; // $s now contains only <li>...</li>, for hooks' convenience.
-		$this->insertDateHeader( $dateheader, $rc->mAttribs['rc_timestamp'] );
-
 		$s = '';
 		$classes = array();
 		// use mw-line-even/mw-line-odd class only if linenumber is given (feature from bug 14468)
@@ -128,6 +125,9 @@ class OldChangesList extends ChangesList {
 
 		wfProfileOut( __METHOD__ );
 
+		$dateheader = ''; // $s now contains only <li>...</li>, for hooks' convenience.
+		$this->insertDateHeader( $dateheader, $rc->mAttribs['rc_timestamp'] );
+
 		return "$dateheader<li class=\"" . implode( ' ', $classes ) . "\">" . $s . "</li>\n";
 	}
 }