From: Aaron Schulz <aschulz@wikimedia.org>
Date: Wed, 9 Jan 2013 18:29:23 +0000 (-0800)
Subject: [JobQueue] Improved de-duplication stat calls.
X-Git-Tag: 1.31.0-rc.0~21090^2
X-Git-Url: http://git.cyclocoop.org/fichier?a=commitdiff_plain;h=13f135b53aa3376d6b8d21f737b59b844c2c8914;p=lhc%2Fweb%2Fwiklou.git

[JobQueue] Improved de-duplication stat calls.

Change-Id: Ib8e3452c9e42b20389c515e7dd8e030b0900497d
---

diff --git a/includes/job/JobQueueDB.php b/includes/job/JobQueueDB.php
index 7f4300ca33..8c81cf0702 100644
--- a/includes/job/JobQueueDB.php
+++ b/includes/job/JobQueueDB.php
@@ -181,6 +181,8 @@ class JobQueueDB extends JobQueue {
 						$dbw->insert( 'job', $rowBatch, __METHOD__ );
 					}
 					wfIncrStats( 'job-insert', count( $rows ) );
+					wfIncrStats( 'job-insert-duplicate',
+						count( $rowSet ) + count( $rowList ) - count( $rows ) );
 				} catch ( DBError $e ) {
 					if ( $atomic ) {
 						$dbw->rollback( __METHOD__ );
@@ -245,7 +247,7 @@ class JobQueueDB extends JobQueue {
 			$job->id = $row->job_id; // XXX: work around broken subclasses
 			// Flag this job as an old duplicate based on its "root" job...
 			if ( $this->isRootJobOldDuplicate( $job ) ) {
-				wfIncrStats( 'job-duplicate' );
+				wfIncrStats( 'job-pop-duplicate' );
 				$job = DuplicateJob::newFromJob( $job ); // convert to a no-op
 			}
 			break; // done