More HTML validation checks on page subtitle. Not exploitable, but could create valid...
authorBrion Vibber <brion@users.mediawiki.org>
Thu, 25 Aug 2005 04:31:46 +0000 (04:31 +0000)
committerBrion Vibber <brion@users.mediawiki.org>
Thu, 25 Aug 2005 04:31:46 +0000 (04:31 +0000)
includes/SpecialRecentchangeslinked.php
includes/SpecialWatchlist.php

index cdeb225..08ca2dc 100644 (file)
@@ -36,7 +36,7 @@ function wfSpecialRecentchangeslinked( $par = NULL ) {
        }
        $id = $nt->getArticleId();
        
-       $wgOut->setSubtitle( wfMsg( 'rclsub', $nt->getPrefixedText() ) );
+       $wgOut->setSubtitle( htmlspecialchars( wfMsg( 'rclsub', $nt->getPrefixedText() ) ) );
 
        if ( ! $days ) {
                $days = $wgUser->getOption( 'rcdays' );
index a90f149..c0accda 100644 (file)
@@ -22,7 +22,7 @@ function wfSpecialWatchlist( $par ) {
        $fname = 'wfSpecialWatchlist';
 
        $wgOut->setPagetitle( wfMsg( 'watchlist' ) );
-       $sub = wfMsg( 'watchlistsub', $wgUser->getName() );
+       $sub = htmlspecialchars( wfMsg( 'watchlistsub', $wgUser->getName() ) );
        $wgOut->setSubtitle( $sub );
        $wgOut->setRobotpolicy( 'noindex,nofollow' );