new-installer: WebInstaller's ->finish method needs to be public, not private
authorÆvar Arnfjörð Bjarmason <avar@users.mediawiki.org>
Wed, 7 Jul 2010 10:55:53 +0000 (10:55 +0000)
committerÆvar Arnfjörð Bjarmason <avar@users.mediawiki.org>
Wed, 7 Jul 2010 10:55:53 +0000 (10:55 +0000)
It's called from new-index.php if we can't start a session:

    $installer = new WebInstaller( $wgRequest );

    if ( !$installer->startSession() ) {
     $installer->finish();

Resulting in:

    [07-Jul-2010 10:37:00] PHP Fatal error:  Call to private method WebInstaller::finish() from context '' in /home/avar/g/phase3/config/new-index.php on line 12

includes/installer/WebInstaller.php

index 5fde975..9a5b664 100644 (file)
@@ -278,7 +278,7 @@ class WebInstaller extends Installer {
        /**
         * Clean up from execute()
         */
-       private function finish() {
+       public function finish() {
                $this->output->output();
                $this->session['happyPages'] = $this->happyPages;
                $this->session['skippedPages'] = $this->skippedPages;