vector.collapsibleTabs: Rename $settings to settings
authorTimo Tijhof <krinklemail@gmail.com>
Fri, 16 May 2014 16:08:59 +0000 (18:08 +0200)
committerTimo Tijhof <krinklemail@gmail.com>
Fri, 16 May 2014 16:08:59 +0000 (18:08 +0200)
This is just a plain object.

Change-Id: I062e2a081e605a002c841ad69fe0dcd90fbee057

skins/vector/collapsibleTabs.js

index 0e49744..9344433 100644 (file)
@@ -9,7 +9,7 @@
                        return this;
                }
                // Merge options into the defaults
-               var $settings = $.extend( {}, $.collapsibleTabs.defaults, options );
+               var settings = $.extend( {}, $.collapsibleTabs.defaults, options );
 
                this.each( function () {
                        var $el = $( this );
@@ -17,9 +17,9 @@
                        $.collapsibleTabs.instances = ( $.collapsibleTabs.instances.length === 0 ?
                                $el : $.collapsibleTabs.instances.add( $el ) );
                        // attach the settings to the elements
-                       $el.data( 'collapsibleTabsSettings', $settings );
+                       $el.data( 'collapsibleTabsSettings', settings );
                        // attach data to our collapsible elements
-                       $el.children( $settings.collapsible ).each( function () {
+                       $el.children( settings.collapsible ).each( function () {
                                $.collapsibleTabs.addData( $( this ) );
                        } );
                } );
                        }
                },
                addData: function ( $collapsible ) {
-                       var $settings = $collapsible.parent().data( 'collapsibleTabsSettings' );
-                       if ( $settings ) {
+                       var settings = $collapsible.parent().data( 'collapsibleTabsSettings' );
+                       if ( settings ) {
                                $collapsible.data( 'collapsibleTabsSettings', {
-                                       expandedContainer: $settings.expandedContainer,
-                                       collapsedContainer: $settings.collapsedContainer,
+                                       expandedContainer: settings.expandedContainer,
+                                       collapsedContainer: settings.collapsedContainer,
                                        expandedWidth: $collapsible.width(),
                                        prevElement: $collapsible.prev()
                                } );
                        }
                },
                getSettings: function ( $collapsible ) {
-                       var $settings = $collapsible.data( 'collapsibleTabsSettings' );
-                       if ( !$settings ) {
+                       var settings = $collapsible.data( 'collapsibleTabsSettings' );
+                       if ( !settings ) {
                                $.collapsibleTabs.addData( $collapsible );
-                               $settings = $collapsible.data( 'collapsibleTabsSettings' );
+                               settings = $collapsible.data( 'collapsibleTabsSettings' );
                        }
-                       return $settings;
+                       return settings;
                },
                handleResize: function () {
                        $.collapsibleTabs.instances.each( function () {