new-installer: Make findExtensions() return a key-value array

Now we return e.g.:

    array( 'Cite', 'LiquidThreads' );

Instead return:

    array(
        'Cite' => null,
        'LiquidThreads' => $some_config
    );

Where $some_config is a yet-to-be determined configuration. It's
intended for e.g. sourcing SQL tables that the extension needs.

diff --git a/includes/installer/Installer.php b/includes/installer/Installer.php
index 4124028..9ab53fa 100644 (file)
--- a/includes/installer/Installer.php
+++ b/includes/installer/Installer.php
@@ -844,7 +844,7 @@ abstract class Installer {
                $dh = opendir( $dir );
                while ( ( $file = readdir( $dh ) ) !== false ) {
                        if( file_exists( "$dir/$file/$file.php" ) ) {
-                               $exts[] = $file;
+                               $exts[$file] = null;
                        }
                }
                $this->setVar( '_Extensions', $exts );

diff --git a/includes/installer/WebInstaller.php b/includes/installer/WebInstaller.php
index c5bc3dd..ff6609a 100644 (file)
--- a/includes/installer/WebInstaller.php
+++ b/includes/installer/WebInstaller.php
@@ -1387,7 +1387,7 @@ class WebInstaller_Options extends WebInstallerPage {
                $extensions = $this->parent->findExtensions();
                if( $extensions ) {
                        $extHtml = $this->parent->getFieldsetStart( 'config-extensions' );
-                       foreach( $extensions as $ext ) {
+                       foreach( array_keys($extensions) as $ext ) {
                                $extHtml .= $this->parent->getCheckBox( array(
                                        'var' => "ext-$ext",
                                        'rawtext' => $ext,