Fix SpecialVersion->formatCredits input. Version and Url parameters should be null...

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index b376941..456253f 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -37,6 +37,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bugs 5051, 5376) Tooltips and accesskeys no longer require JavaScript
 * Added SkinTemplateOutputPageBeforeExec hook before SkinTemplate::outputPage()
   starts page output (http://lists.wikimedia.org/pipermail/wikitech-l/2007-January/028554.html)
+* Fix SpecialVersion->formatCredits input. Version and Url parameters should be null
+  to be treated properly with isset.
 
 == Languages updated ==
 

diff --git a/includes/SpecialVersion.php b/includes/SpecialVersion.php
index 36da5ca..cdd31f5 100644 (file)
--- a/includes/SpecialVersion.php
+++ b/includes/SpecialVersion.php
@@ -118,9 +118,9 @@ class SpecialVersion {
                                foreach ( $wgExtensionCredits[$type] as $extension ) {
                                        $out .= $this->formatCredits(
                                                isset ( $extension['name'] )        ? $extension['name']        : '',
-                                               isset ( $extension['version'] )     ? $extension['version']     : '',
+                                               isset ( $extension['version'] )     ? $extension['version']     : null,
                                                isset ( $extension['author'] )      ? $extension['author']      : '',
-                                               isset ( $extension['url'] )         ? $extension['url']         : '',
+                                               isset ( $extension['url'] )         ? $extension['url']         : null,
                                                isset ( $extension['description'] ) ? $extension['description'] : ''
                                        );
                                }
@@ -193,7 +193,7 @@ class SpecialVersion {
 
                        foreach ($myWgHooks as $hook => $hooks)
                                $ret .= "<tr><td>$hook</td><td>" . $this->listToText( $hooks ) . "</td></tr>\n";
-                       
+
                        $ret .= '</table>';
                        return $ret;
                } else