Revert r46447 in Collection -- fixed bug in Categoryfinder class it was trying to...
authorBrion Vibber <brion@users.mediawiki.org>
Thu, 29 Jan 2009 01:29:43 +0000 (01:29 +0000)
committerBrion Vibber <brion@users.mediawiki.org>
Thu, 29 Jan 2009 01:29:43 +0000 (01:29 +0000)
commite136d9c6a70e424d8b22949887a6826f8ebab69e
treedf13452390831be05075de6bd40683d28662ebba
parenta9b78e1db910c9a9ac9306795d224bf7ad0d115f
Revert r46447 in Collection -- fixed bug in Categoryfinder class it was trying to work around.
Categoryfinder::seed() was passing category names through Title::newFromText($ct,NS_CATEGORY), which meant that if the name started with what looks like a namespace, that would override the NS_CATEGORY default.
Thus you got 'Wikipedia:Books' -> text portion 'Books' when you wanted 'Category:Wikipedia:Books' -> text portion 'Wikipedia:Books'.
Using Title::makeTitleSafe(NS_CATEGORY,$ct) instead forces it to always use the category namespace.
Additionally, I've added a check for invalid input -- previously a bad input leading to an invalid title would just kill it dead with a fatal error. Invalid input in the category list is now skipped.
RELEASE-NOTES
includes/Categoryfinder.php