From fcc2895cad2d981c08e03ad2a14f0a02ad069e39 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Thu, 20 Apr 2017 11:29:25 -0700 Subject: [PATCH] Fix bogus variable use in RefreshLinksJob::run() Also removed two unused loop variables. Change-Id: I9a9e0a83bdaa13c031857bc20f977161cf85baff --- includes/jobqueue/jobs/RefreshLinksJob.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/includes/jobqueue/jobs/RefreshLinksJob.php b/includes/jobqueue/jobs/RefreshLinksJob.php index 64d955ae96..02bb829e1a 100644 --- a/includes/jobqueue/jobs/RefreshLinksJob.php +++ b/includes/jobqueue/jobs/RefreshLinksJob.php @@ -87,7 +87,7 @@ class RefreshLinksJob extends Job { // When the base job branches, wait for the replica DBs to catch up to the master. // From then on, we know that any template changes at the time the base job was // enqueued will be reflected in backlink page parses when the leaf jobs run. - if ( !isset( $params['range'] ) ) { + if ( !isset( $this->params['range'] ) ) { try { $lbFactory = MediaWikiServices::getInstance()->getDBLoadBalancerFactory(); $lbFactory->waitForReplication( [ @@ -113,7 +113,7 @@ class RefreshLinksJob extends Job { JobQueueGroup::singleton()->push( $jobs ); // Job to update link tables for a set of titles } elseif ( isset( $this->params['pages'] ) ) { - foreach ( $this->params['pages'] as $pageId => $nsAndKey ) { + foreach ( $this->params['pages'] as $nsAndKey ) { list( $ns, $dbKey ) = $nsAndKey; $this->runForTitle( Title::makeTitleSafe( $ns, $dbKey ) ); } @@ -253,7 +253,7 @@ class RefreshLinksJob extends Job { // This avoids snapshot-clearing errors in LinksUpdate::acquirePageLock(). $lbFactory->commitAndWaitForReplication( __METHOD__, $ticket ); - foreach ( $updates as $key => $update ) { + foreach ( $updates as $update ) { // FIXME: This code probably shouldn't be here? // Needed by things like Echo notifications which need // to know which user caused the links update -- 2.20.1