From dd2de0ed9fb905cb59c6e0ddf17a7461832d7342 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Mon, 11 Feb 2013 16:53:25 -0800 Subject: [PATCH] Fixed unmatched begin/commit in SiteStatsUpdate. Change-Id: Iaea0334571a283a72d9a070508d6175cd5b8d9bf --- includes/SiteStats.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/includes/SiteStats.php b/includes/SiteStats.php index 01841b67db..addaddd698 100644 --- a/includes/SiteStats.php +++ b/includes/SiteStats.php @@ -294,8 +294,6 @@ class SiteStatsUpdate implements DeferrableUpdate { $this->doUpdatePendingDeltas(); } else { $dbw = wfGetDB( DB_MASTER ); - // Need a separate transaction because this a global lock - $dbw->begin( __METHOD__ ); $lockKey = wfMemcKey( 'site_stats' ); // prepend wiki ID if ( $rate ) { @@ -316,6 +314,9 @@ class SiteStatsUpdate implements DeferrableUpdate { $this->images += ( $pd['ss_images']['+'] - $pd['ss_images']['-'] ); } + // Need a separate transaction because this a global lock + $dbw->begin( __METHOD__ ); + // Build up an SQL query of deltas and apply them... $updates = ''; $this->appendUpdate( $updates, 'ss_total_views', $this->views ); -- 2.20.1