From b77eaa1a1a62ac0ed76f766fdeda4dc0a39ebcf0 Mon Sep 17 00:00:00 2001 From: Siebrand Mazeland Date: Mon, 28 Sep 2015 14:19:29 +0200 Subject: [PATCH] Fix two PHPCS warnings in NaiveForeignTitleFactory.php Change-Id: I61f1e1beab7e6fdd6e817b728a837d4ea57f435f --- includes/title/NaiveForeignTitleFactory.php | 22 +++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/includes/title/NaiveForeignTitleFactory.php b/includes/title/NaiveForeignTitleFactory.php index 6c8bcc04e8..2c2f94b2a2 100644 --- a/includes/title/NaiveForeignTitleFactory.php +++ b/includes/title/NaiveForeignTitleFactory.php @@ -45,16 +45,18 @@ class NaiveForeignTitleFactory implements ForeignTitleFactory { global $wgContLang; - // Can we assume that the part of the page title before the colon is a - // namespace name? - // - // XML export schema version 0.5 and earlier (MW 1.18 and earlier) does not - // contain a tag, so we need to be able to handle that case. - // - // If we know the namespace ID, we assume a non-zero namespace ID means - // the ':' sets off a valid namespace name. If we don't know the namespace - // ID, we fall back to using the local wiki's namespace names to resolve - // this -- better than nothing, and mimics the old crappy behavior + /** + * Can we assume that the part of the page title before the colon is a + * namespace name? + * + * XML export schema version 0.5 and earlier (MW 1.18 and earlier) does not + * contain a tag, so we need to be able to handle that case. + * + * If we know the namespace ID, we assume a non-zero namespace ID means + * the ':' sets off a valid namespace name. If we don't know the namespace + * ID, we fall back to using the local wiki's namespace names to resolve + * this -- better than nothing, and mimics the old crappy behavior + */ $isNamespacePartValid = is_null( $ns ) ? ( $wgContLang->getNsIndex( $pieces[0] ) !== false ) : $ns != 0; -- 2.20.1