From afe8d1cff90c967f8a5a38eea15499716a1d09d2 Mon Sep 17 00:00:00 2001 From: Sam Reed Date: Wed, 11 Jan 2012 21:52:44 +0000 Subject: [PATCH] * (bug 33117) prop=revisions allows deleted text to be exposed through cache pollution --- includes/api/ApiQueryRevisions.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/api/ApiQueryRevisions.php b/includes/api/ApiQueryRevisions.php index a89d501979..fa58bdf047 100644 --- a/includes/api/ApiQueryRevisions.php +++ b/includes/api/ApiQueryRevisions.php @@ -131,7 +131,7 @@ class ApiQueryRevisions extends ApiQueryBase { if ( !$difftoRev ) { $this->dieUsageMsg( array( 'nosuchrevid', $params['diffto'] ) ); } - if ( !$difftoRev->userCan( Revision::DELETED_TEXT ) ) { + if ( $difftoRev->isDeleted( Revision::DELETED_TEXT ) ) { $this->setWarning( "Couldn't diff to r{$difftoRev->getID()}: content is hidden" ); $params['diffto'] = null; } -- 2.20.1