From 90f9b730c9244ac0b53cb18292c5af0313817591 Mon Sep 17 00:00:00 2001 From: Derk-Jan Hartman Date: Fri, 5 Nov 2010 01:42:28 +0000 Subject: [PATCH] Add width to the cache key for thumburls in InstantCommons. No point in not caching multiple sizes if we can, must have been an oversight. --- RELEASE-NOTES | 1 + includes/filerepo/ForeignAPIRepo.php | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 84be7850c7..3e221d075a 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -396,6 +396,7 @@ LocalSettings.php. The specific bugs are listed below in the general notes. * (bug 16902) Installer spews warnings when exec() and dl() are not available * (bug 19129) Only show MyISAM/InnoDB when supported * (bug 17762) Only show other e-mail options when e-mail is globally enabled +* Cache multiple sizes of InstantCommons thumbnails === API changes in 1.17 === * (bug 22738) Allow filtering by action type on query=logevent. diff --git a/includes/filerepo/ForeignAPIRepo.php b/includes/filerepo/ForeignAPIRepo.php index f6b21ee99d..631acf27a4 100644 --- a/includes/filerepo/ForeignAPIRepo.php +++ b/includes/filerepo/ForeignAPIRepo.php @@ -200,7 +200,7 @@ class ForeignAPIRepo extends FileRepo { return $this->getThumbUrl( $name, $width, $height ); } - $key = $this->getLocalCacheKey( 'ForeignAPIRepo', 'ThumbUrl', $name ); + $key = $this->getLocalCacheKey( 'ForeignAPIRepo', 'ThumbUrl', $name, $width ); $thumbUrl = $wgMemc->get($key); if ( $thumbUrl ) { wfDebug("Got thumb from local cache. $thumbUrl \n"); -- 2.20.1