From: Roan Kattouw <roan.kattouw@gmail.com>
Date: Mon, 26 Jun 2017 23:49:52 +0000 (-0700)
Subject: RCFilters: Always use the filled bookmark icon (unClip)
X-Git-Tag: 1.31.0-rc.0~2878^2
X-Git-Url: http://git.cyclocoop.org/ecrire?a=commitdiff_plain;h=a8875303f820de9c7eec32988a8eabf24e0417f0;p=lhc%2Fweb%2Fwiklou.git

RCFilters: Always use the filled bookmark icon (unClip)

Bug: T168828
Change-Id: I436f00bc87db143116125a185abd8000132df195
---

diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
index 3f920f0013..1a68b49f6f 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
@@ -24,7 +24,7 @@
 		// Parent
 		mw.rcfilters.ui.SaveFiltersPopupButtonWidget.parent.call( this, $.extend( {
 			framed: false,
-			icon: 'clip',
+			icon: 'unClip',
 			$overlay: this.$overlay,
 			title: mw.msg( 'rcfilters-savedqueries-add-new-title' ),
 			popup: {
@@ -36,7 +36,7 @@
 			}
 		}, config ) );
 		// // HACK: Add an icon to the popup head label
-		this.popup.$head.prepend( ( new OO.ui.IconWidget( { icon: 'clip' } ) ).$element );
+		this.popup.$head.prepend( ( new OO.ui.IconWidget( { icon: 'unClip' } ) ).$element );
 
 		this.input = new OO.ui.TextInputWidget( {
 			validate: /\S/
@@ -109,15 +109,6 @@
 		}
 	};
 
-	/**
-	 * Respond to popup toggle event
-	 *
-	 * @param {boolean} isVisible Popup is visible
-	 */
-	mw.rcfilters.ui.SaveFiltersPopupButtonWidget.prototype.onPopupToggle = function ( isVisible ) {
-		this.setIcon( isVisible ? 'unClip' : 'clip' );
-	};
-
 	/**
 	 * Respond to popup ready event
 	 */