From: Aryeh Gregor <simetrical@users.mediawiki.org>
Date: Wed, 8 Sep 2010 18:11:28 +0000 (+0000)
Subject: Update comment in Category.php
X-Git-Tag: 1.31.0-rc.0~35087
X-Git-Url: http://git.cyclocoop.org/ecrire?a=commitdiff_plain;h=27d1e4ae23ce2da401e28762cc08a914d83102fd;p=lhc%2Fweb%2Fwiklou.git

Update comment in Category.php

Per code review I gave on r72547.  I'm actually not sure how to rewrite
this so it works with all DBs -- a replace() variant that called
nextSequenceValue() if the row didn't already exist, and reused the
existing id otherwise, would perhaps be ideal.  (Speaking of which,
replace() needs to be properly factored out, with the DBMS-independent
version in DatabaseBase and the MySQL one in DatabaseMysql.)
---

diff --git a/includes/Category.php b/includes/Category.php
index 1e49c5ff89..614933fff2 100644
--- a/includes/Category.php
+++ b/includes/Category.php
@@ -256,8 +256,11 @@ class Category {
 		$dbw = wfGetDB( DB_MASTER );
 		$dbw->begin();
 
-		# Let's be sure that the row exists in the table.  We don't need to
-		# do this if we got the row from the table in initialization!
+		# Insert the row if it doesn't exist yet (e.g., this is being run via
+		# update.php from a pre-1.16 schema).  TODO: This will cause lots and
+		# lots of gaps on some non-MySQL DBMSes if you run populateCategory.php
+		# repeatedly.  Plus it's an extra query that's unneeded almost all the
+		# time.  This should be rewritten somehow, probably.
 		$seqVal = $dbw->nextSequenceValue( 'category_cat_id_seq' );
 		$dbw->insert(
 			'category',