Followup r78117: information was still leaked through the caption of the Edit tab...

diff --git a/includes/SkinTemplate.php b/includes/SkinTemplate.php
index 7821a58..6ec0d20 100644 (file)
--- a/includes/SkinTemplate.php
+++ b/includes/SkinTemplate.php
@@ -754,7 +754,7 @@ class SkinTemplate extends Skin {
                        );
 
                        wfProfileIn( __METHOD__ . '-edit' );
-                       if ( $this->mTitle->quickUserCan( 'edit' ) && ( $this->mTitle->exists() || $this->mTitle->quickUserCan( 'create' ) ) ) {
+                       if ( $userCanRead && $this->mTitle->quickUserCan( 'edit' ) && ( $this->mTitle->exists() || $this->mTitle->quickUserCan( 'create' ) ) ) {
                                $istalk = $this->mTitle->isTalkPage();
                                $istalkclass = $istalk?' istalk':'';
                                $content_actions['edit'] = array(

diff --git a/skins/Vector.php b/skins/Vector.php
index 27fb9e8..77acefe 100644 (file)
--- a/skins/Vector.php
+++ b/skins/Vector.php
@@ -115,8 +115,8 @@ class SkinVector extends SkinTemplate {
 
                        // Checks if user can...
                        if (
-                               // edit the current page
-                               $this->mTitle->quickUserCan( 'edit' ) &&
+                               // read and edit the current page
+                               $userCanRead && $this->mTitle->quickUserCan( 'edit' ) &&
                                (
                                        // if it exists
                                        $this->mTitle->exists() ||