Merge "Make sure a job is logged as OK if the status is NULL for sanity."
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Tue, 9 Apr 2013 18:24:43 +0000 (18:24 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Tue, 9 Apr 2013 18:24:43 +0000 (18:24 +0000)
maintenance/runJobs.php

index abe8335..66d8028 100644 (file)
@@ -108,7 +108,7 @@ class RunJobs extends Maintenance {
                                        $group->ack( $job ); // done
                                }
 
-                               if ( !$status ) {
+                               if ( $status === false ) {
                                        $this->runJobsLog( $job->toString() . " t=$timeMs error={$error}" );
                                } else {
                                        $this->runJobsLog( $job->toString() . " t=$timeMs good" );